Properly calculate penumbra for soft shadows with reverse z #91191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a related bug where the DirectionalLight3D size was ignored unless a positional light with soft shadows touched the mesh
|
Thanks, guys. Hope this gets merged soon if it's in good enough of a state to do so. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #91142
For omnilights, the blocker search flipped the comparison appropriately already, but for all light types the penumbra calculation was broken. They all work now.
The other change uses the spec constant for directional light soft shadows when calculating size_A. Its just a typo that needs to be cleaned up. The current behaviour is the DirectionalLight3D size is ignored unless a positional light with soft shadows touched the mesh.